Re: Add --{no-,}bypassrls flags to createuser

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Shinya Kato <Shinya11(dot)Kato(at)oss(dot)nttdata(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, przemyslaw(at)sztoch(dot)pl, david(dot)g(dot)johnston(at)gmail(dot)com, robertmhaas(at)gmail(dot)com, daniel(at)yesql(dot)se, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Add --{no-,}bypassrls flags to createuser
Date: 2022-05-26 16:20:37
Message-ID: 20220526162037.GA1345023@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 26, 2022 at 02:16:37PM +0900, Shinya Kato wrote:
> On 2022-05-25 11:07, Kyotaro Horiguchi wrote:
>> At Tue, 24 May 2022 10:09:10 -0700, Nathan Bossart
>> <nathandbossart(at)gmail(dot)com> wrote in
>> > We're still missing some "fancier" string patterns in the tests, but
>> > we
>> > might just be nitpicking at this point.
>>
>> Such "fancier" strings should be properly handled by FmtId() and
>> appendStringLiteralConn. If this is a privilege escalating command,
>> we should have ones but this is not.
>
> Sorry, I didn't quite understand the "fancier" pattern. Is a string like
> this patch correct?

Yes, thanks. I'm marking this as ready-for-committer.

--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-05-26 16:57:55 Re: doc: CREATE FOREIGN TABLE .. PARTITION OF .. DEFAULT
Previous Message Masahiko Sawada 2022-05-26 15:43:12 Re: Add index scan progress to pg_stat_progress_vacuum