Re: fix stats_fetch_consistency value in postgresql.conf.sample

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: pryzby(at)telsasoft(dot)com
Cc: michael(at)paquier(dot)xyz, andres(at)anarazel(dot)de, nathandbossart(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: fix stats_fetch_consistency value in postgresql.conf.sample
Date: 2022-05-26 07:27:53
Message-ID: 20220526.162753.632795261813283794.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Thu, 26 May 2022 13:00:45 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> At Wed, 25 May 2022 21:25:53 -0500, Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote in
> > And I think these should be updated it postgresql.conf to use the same unit as
> > in current_setting().
> >
> > track_activity_query_size | 1kB | 1024
> > wal_buffers | 4MB | -1
> > wal_receiver_timeout | 1min | 60s
> > wal_sender_timeout | 1min | 60s
>
> I'm not sure we should do so. Rather I'd prefer 60s than 1min here.

It could be in SQL, but *I* prefer to use perl for this, since it
allows me to write a bit complex things (than simple string
comparison) simpler.

So the attached is a wip version of that

Numeric values are compared considering units. But does not require
the units of the both values to match. Some variables are ignored by
an explicit instruction (ignored_parameters). Some variables are
compared case-insensitively by an explicit instruction
(case_insensitive_params). bool and enum are compared
case-insensitively automatically.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
0001-Add-fileval-bootval-consistency-check-of-GUC-paramet.patch text/x-patch 6.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2022-05-26 07:47:46 Re: Add --{no-,}bypassrls flags to createuser
Previous Message Julien Rouhaud 2022-05-26 07:26:57 Re: Allow file inclusion in pg_hba and pg_ident files