Re: tweak to a few index tests to hits ambuildempty() routine.

From: Noah Misch <noah(at)leadboat(dot)com>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Amul Sul <sulamul(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: tweak to a few index tests to hits ambuildempty() routine.
Date: 2022-05-22 04:54:27
Message-ID: 20220522045427.GA3015504@rfd.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, May 22, 2022 at 04:24:16PM +1200, Thomas Munro wrote:
> On Sat, May 21, 2022 at 6:15 PM Noah Misch <noah(at)leadboat(dot)com> wrote:
> > On Mon, Apr 25, 2022 at 10:05:08AM -0400, Tom Lane wrote:
> > > Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > > > Hmm, so 027_stream_regress.pl is not prepared to deal with any unlogged
> > > > tables that may be left in the regression database (which is what my
> > > > spgist addition did). I first tried doing a TRUNCATE of the unlogged
> > > > table, but that doesn't work either, and it turns out that the
> > > > regression database does not have any UNLOGGED relations. Maybe that's
> > > > something we need to cater for, eventually, but for now dropping the
> > > > table suffices. I have pushed that.
> > >
> > > It does seem like the onus should be on 027_stream_regress.pl to
> > > deal with that, rather than restricting what the core tests can
> > > leave behind.
> >
> > Yeah. Using "pg_dumpall --no-unlogged-table-data", as attached, suffices.
>
> 'pg_dumpall', '-f', $outputdir . '/primary.dump',
> - '--no-sync', '-p', $node_primary->port
> + '--no-sync', '-p', $node_primary->port,
> + '--no-unlogged-table-data' # if unlogged, standby
> has schema only
>
> LGTM, except for the stray extra whitespace.

perltidy contributes the prior-line whitespace change.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Gurjeet Singh 2022-05-22 06:41:18 Patch: Don't set LoadedSSL unless secure_initialize succeeds
Previous Message mahendrakar s 2022-05-22 04:44:17 Re: Enforce "max_wal_size/ min_wal_size must be at least twice wal_segment_size" limit while setting GUCs