Re: [RFC] building postgres with meson -v8

Hi,

On 2022-05-16 17:47:24 +0200, Peter Eisentraut wrote:
> On 12.05.22 21:30, Andres Freund wrote:
> > On 2022-05-11 12:18:58 +0200, Peter Eisentraut wrote:
> > > I fixed the Perl detection issue in my macOS environment that I had reported
> > > a while ago.
> >
> > Hm. I wonder if it's right to check with is_file() - perhaps there are
> > platforms that have split off the include directory?
>
> The existing code uses "test -f", so using is_file() would keep it working
> the same way.

I merged it that way. Merged.

> > > From 049b34b6a8dd949f0eb7987cad65f6682a6ec786 Mon Sep 17 00:00:00 2001
> > > From: Peter Eisentraut <peter(at)eisentraut(dot)org>
> > > Date: Wed, 11 May 2022 09:06:13 +0200
> > > Subject: [PATCH 3/9] meson: prereq: Refactor dtrace postprocessing make rules
> > >
> > > Move the dtrace postprocessing sed commands into a separate file so
> > > that it can be shared by meson. Also split the rule into two for
> > > proper dependency declaration.
> >
> > Hm. Using sed may be problematic on windows...
>
> This code is only used when dtrace is enabled, which probably doesn't apply
> on Windows.

Fair point. Merged.

Greetings,

Andres Freund