| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Declaration fixes |
| Date: | 2022-05-12 16:45:13 |
| Message-ID: | 20220512164513.vaheofqp2q24l65r@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I was experimenting with specifying symbol visiblity for functions explicitly,
i.e. adding PGDLLIMPORT markers for them, with the goal of getting rid of
src/tools/msvc/gendef.pl (and similar AIX stuff). While doing that I compared
the set of exported symbols before / after, leading me to find a few
pre-existing "issues".
I think the attached patches are all a good idea and trivial enought that I
think we should apply them now.
The changes are sufficiently obvious and/or explained in the commit messages.
Comments?
Greetings,
Andres Freund
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Add-missing-extern-to-function-prototypes.patch | text/x-diff | 16.0 KB |
| v1-0002-Add-static-to-file-local-variables-missing-it.patch | text/x-diff | 5.6 KB |
| v1-0003-Add-missing-binary_upgrade.h-where-includes.patch | text/x-diff | 1.5 KB |
| v1-0004-Remove-function-declaration-for-function-in-pg_pr.patch | text/x-diff | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-05-12 17:18:05 | Re: Declaration fixes |
| Previous Message | Andres Freund | 2022-05-12 16:33:05 | Re: Crash in new pgstats code |