From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
---|---|
To: | "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, etsuro(dot)fujita(at)gmail(dot)com |
Subject: | Re: postgres_fdw "parallel_commit" docs |
Date: | 2022-05-09 15:58:15 |
Message-ID: | 20220509155815.GR28830@telsasoft.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, May 09, 2022 at 11:37:35AM -0400, Jonathan S. Katz wrote:
> @@ -473,27 +473,25 @@ OPTIONS (ADD password_required 'false');
> <term><literal>parallel_commit</literal> (<type>boolean</type>)</term>
> <listitem>
> <para>
> - This option controls whether <filename>postgres_fdw</filename> commits
> - remote (sub)transactions opened on a foreign server in a local
> - (sub)transaction in parallel when the local (sub)transaction commits.
> - This option can only be specified for foreign servers, not per-table.
> - The default is <literal>false</literal>.
> + This option controls whether <filename>postgres_fdw</filename> commits in
> + parallel remote transactions opened on a foreign server in a local
> + transaction when the local transaction is committed. This setting
> + applies to remote and local substransactions. This option can only be
typo: substransactions
> - If multiple foreign servers with this option enabled are involved in
> - a local (sub)transaction, multiple remote (sub)transactions opened on
> - those foreign servers in the local (sub)transaction are committed in
> - parallel across those foreign servers when the local (sub)transaction
> - commits.
> + If multiple foreign servers with this option enabled have a local
> + transaction, multiple remote transactions on those foreign servers are
> + committed in parallel across those foreign servers when the local
> + transaction is committed.
> </para>
I think "have a transaction" doesn't sound good, and the old language "involved
in" was better.
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2022-05-09 16:42:44 | Re: Query generates infinite loop |
Previous Message | Tom Lane | 2022-05-09 15:56:05 | psql now shows zero elapsed time after an error |