| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Unstable tests for recovery conflict handling |
| Date: | 2022-04-28 01:31:34 |
| Message-ID: | 20220428013134.gahwtxwfuu6gwfwe@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hi,
On 2022-04-27 14:08:45 -0400, Tom Lane wrote:
> I wrote:
> > It's been kind of hidden by other buildfarm noise, but
> > 031_recovery_conflict.pl is not as stable as it should be [1][2][3][4].
> > ...
> > I think this is showing us a real bug, ie we sometimes fail to cancel
> > the conflicting query.
>
> After digging around in the code, I think this is almost certainly
> some manifestation of the previously-complained-of problem [1] that
> RecoveryConflictInterrupt is not safe to call in a signal handler,
> leading the conflicting backend to sometimes decide that it's not
> the problem.
I think at least some may actually be because of
https://postgr.es/m/20220409045515.35ypjzddp25v72ou%40alap3.anarazel.de
rather than RecoveryConflictInterrupt itself.
I'll go an finish up the comment bits that I still need to clean up in my
bugix and commit that...
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-04-28 02:12:42 | pgsql: Remove durable_rename_excl() |
| Previous Message | Andres Freund | 2022-04-28 01:26:34 | Re: Unstable tests for recovery conflict handling |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Junwang Zhao | 2022-04-28 01:54:10 | Re: remove redundant check of item pointer |
| Previous Message | Andres Freund | 2022-04-28 01:26:34 | Re: Unstable tests for recovery conflict handling |