| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | michael(at)paquier(dot)xyz |
| Cc: | robertmhaas(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, markus(dot)wanner(at)enterprisedb(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: API stability |
| Date: | 2022-04-08 01:32:55 |
| Message-ID: | 20220408.103255.1640071788970978147.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
At Fri, 8 Apr 2022 08:47:42 +0900, Michael Paquier <michael(at)paquier(dot)xyz> wrote in
> On Thu, Apr 07, 2022 at 11:19:15AM -0400, Robert Haas wrote:
> > Here are patches for master and v14 to do things this way. Comments?
>
> Thanks for the patches. They look correct. For ~14, I'd rather avoid
> the code duplication done by GetVirtualXIDsDelayingChkptEnd() and
> HaveVirtualXIDsDelayingChkpt() that could be avoided with an extra
> bool argument to the existing routine. The same kind of duplication
> happens with GetVirtualXIDsDelayingChkpt() and
> GetVirtualXIDsDelayingChkptEnd().
FWIW, it is done in [1].
[1] https://www.postgresql.org/message-id/20220406.164521.17171257901083417.horikyota.ntt%40gmail.com
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2022-04-08 01:34:55 | Re: API stability |
| Previous Message | Andres Freund | 2022-04-08 01:22:58 | pgsql: pgstat: Hide instability in stats.spec with -DCATCACHE_FORCE_REL |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2022-04-08 01:34:55 | Re: API stability |
| Previous Message | Andres Freund | 2022-04-08 01:22:57 | Re: test/isolation/expected/stats_1.out broken for me |