Re: Remove error message hints mentioning configure options

From: Andres Freund <andres(at)anarazel(dot)de>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove error message hints mentioning configure options
Date: 2022-04-07 07:34:31
Message-ID: 20220407073431.wugvrnnbquusstkt@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jo.

On 2022-04-07 09:19:14 +0200, Peter Eisentraut wrote:
> I think these hints are usually not useful since users will use packaged
> distributions and won't be interested in rebuilding their installation from
> source. Also, we have only used these kinds of hints for some features and
> in some places, not consistently throughout. And of course there are build
> systems that don't use configure. The information "needs to be built with
> XXX" or "was not built with XXX" should be enough for those interested in
> actually changing their build configuration to figure out what to do.

+1

> diff --git a/src/test/regress/expected/compression_1.out b/src/test/regress/expected/compression_1.out
> index 1ce2962d55..c0a47646eb 100644
> --- a/src/test/regress/expected/compression_1.out
> +++ b/src/test/regress/expected/compression_1.out

The xml stuff is at least old, but compression_1 isn't. I think we've tried to
avoid long alternative output files where everything fails due to being
unsupported for a while now? Robert, Dilip? See uses of :skip_test in various
tests.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-04-07 07:36:32 Re: Add last commit LSN to pg_last_committed_xact()
Previous Message Andres Freund 2022-04-07 07:28:45 Re: shared-memory based stats collector - v70