| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Alexey Lesovsky <lesovsky(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Skipping logical replication transactions on subscriber side |
| Date: | 2022-04-05 07:08:16 |
| Message-ID: | 20220405070816.GC3827588@rfd.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 05, 2022 at 03:05:10PM +0900, Masahiko Sawada wrote:
> I've attached an updated patch. The patch includes a regression test
> to detect the new violation as we discussed. I've confirmed that
> Cirrus CI tests pass. Please confirm on AIX and review the patch.
When the context of a "git grep skiplsn" match involves several struct fields
in struct order, please change to the new order. In other words, do for all
"git grep skiplsn" matches what the v2 patch does in GetSubscription(). The
v2 patch does not do this for catalogs.sgml, but it ought to. I didn't check
all the other "git grep" matches; please do so.
The changes present in this patch all look good.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | gkokolatos | 2022-04-05 07:13:35 | Re: Add LZ4 compression in pg_dump |
| Previous Message | Amit Kapila | 2022-04-05 06:15:50 | Re: Handle infinite recursion in logical replication setup |