| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Removing more vacuumlazy.c special cases, relfrozenxid optimizations |
| Date: | 2022-04-05 03:18:02 |
| Message-ID: | 20220405031802.dndg3n4d34iysvzl@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2022-04-04 19:32:13 -0700, Peter Geoghegan wrote:
> On Fri, Apr 1, 2022 at 10:54 AM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> > I also refined the WARNING patch in v15. It now actually issues
> > WARNINGs (rather than PANICs, which were just a temporary debugging
> > measure in v14).
>
> Going to commit this remaining patch tomorrow, barring objections.
The remaining patch are the warnings in vac_update_relstats(), correct? I
guess one could argue they should be LOG rather than WARNING, but I find the
project stance on that pretty impractical. So warning's ok with me.
Not sure why you used errmsg_internal()?
Otherwise LGTM.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2022-04-05 03:25:44 | Re: Removing more vacuumlazy.c special cases, relfrozenxid optimizations |
| Previous Message | Andres Freund | 2022-04-05 03:09:57 | Re: Window Function "Run Conditions" |