Re: remove reset_shared()

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: remove reset_shared()
Date: 2022-03-30 01:19:42
Message-ID: 20220330011942.fpouca2laocok7ng@jrouhaud
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Tue, Mar 29, 2022 at 03:17:02PM -0700, Nathan Bossart wrote:
> Hi hackers,
>
> Is there any reason to keep reset_shared() around anymore? It is now just
> a wrapper function for CreateSharedMemoryAndSemaphores(), and AFAICT the
> information in the comments is already covered by comments in the shared
> memory code. I think it's arguable that the name of the function makes it
> clear that it might recreate the shared memory, but if that is a concern,
> perhaps we could rename the function to something like
> CreateOrRecreateSharedMemoryAndSemaphores().
>
> I've attached a patch that simply removes this wrapper function. This is
> admittedly just nitpicking, so I don't intend to carry this patch further
> if anyone is opposed.

I'm +0.5 for it, it doesn't bring much and makes things a bit harder to
understand, as you need to go through an extra function.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2022-03-30 01:30:32 Re: Add parameter jit_warn_above_fraction
Previous Message Andres Freund 2022-03-30 01:17:57 Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints