| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | er(at)xs4all(dot)nl |
| Cc: | boekewurm+postgres(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: TRAP: FailedAssertion("HaveRegisteredOrActiveSnapshot()", File: "toast_internals.c", Line: 670, PID: 19403) |
| Date: | 2022-03-30 08:58:24 |
| Message-ID: | 20220330.175824.936439875658680065.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Wed, 30 Mar 2022 11:46:13 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> But, in the first place the *fix* has been found to be wrong. I'm
> going to search for the right fix..
FETCH uses the snapshot at DECLARE. So anyhow I needed to set the
queryDesk's snapshot used in PortalRunSelect to the FETCH's portal's
holdSnapshot. What I did in this version is:
1. Add a new member "snapshot" to the type DestReceiver.
2. In PortalRunSelect, set the DECLARE'd query's snapshot to the
member iff the dest is tupelstore and the active snapshot is not
set.
3. In FillPortalStore, copy the snapshot to the portal's holdSnapshot.
4. RunFromStore uses holdSnapshot if any.
I'm not still confident on this, but it should be better than the v1.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Appropriately-set-snapshot-on-cursor-fetch.patch | text/x-patch | 7.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-03-30 08:59:56 | Re: Logical replication timeout problem |
| Previous Message | Amit Kapila | 2022-03-30 08:30:01 | Re: logical replication empty transactions |