| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_stat_get_replication_slot() marked not strict, crashes |
| Date: | 2022-03-28 04:54:12 |
| Message-ID: | 20220328045412.dqxvmnywmnkpizvp@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2022-03-27 21:09:29 -0700, Andres Freund wrote:
> FWIW, I have a test for both, I was a bit "stuck" on where to put the
> pg_stat_get_subscription_stats(NULL) test. I had put the
> pg_stat_get_replication_slot(NULL) in contrib/test_decoding/sql/stats.sql
> but pg_stat_get_subscription_stats() doesn't really fit there. I think I'm
> coming down to putting a section of such tests into src/test/regress/sql/stats.sql
> instead. In the hope of preventing future such occurrances by encouraging
> people to copy the test...
Pushed with tests there.
Vignesh, thanks for the patches! I already had something locally, should have
mentioned that...
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-03-28 05:29:56 | Re: logical decoding and replication of sequences |
| Previous Message | Masahiko Sawada | 2022-03-28 04:42:47 | Re: pg_stat_get_replication_slot() marked not strict, crashes |