| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Georgios <gkokolatos(at)protonmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Rachel Heaton <rachelmheaton(at)gmail(dot)com> |
| Subject: | Re: Add LZ4 compression in pg_dump |
| Date: | 2022-03-26 18:33:36 |
| Message-ID: | 20220326183336.GJ28503@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 26, 2022 at 11:21:56AM -0500, Justin Pryzby wrote:
> You're passing both the compression method *and* level. I think there should
> be a structure which includes both. In the future, that can also handle
> additional options.
I'm not sure if there's anything worth saving, but I did that last year with
0003-Support-multiple-compression-algs-levels-opts.patch
I sent a rebased copy off-list.
https://www.postgresql.org/message-id/flat/20210104025321(dot)GA9712(at)telsasoft(dot)com#ca1b9f9d3552c87fa874731cad9d8391
| fatal("not built with LZ4 support");
| fatal("not built with lz4 support");
Please use consistent capitalization of "lz4" - then the compiler can optimize
away duplicate strings.
> 0004: The include should use <lz4.h> and not "lz4.h"
Also, use USE_LZ4 rather than HAVE_LIBLZ4, per 75eae0908.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-03-26 18:36:37 | Re: [PATCH] Expose port->authn_id to extensions and triggers |
| Previous Message | Robert Haas | 2022-03-26 18:31:31 | Re: Document atthasmissing default optimization avoids verification table scan |