Re: [PATCH] Accept IP addresses in server certificate SANs

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: pchampion(at)vmware(dot)com
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Accept IP addresses in server certificate SANs
Date: 2022-03-24 08:10:54
Message-ID: 20220324.171054.766667370713633185.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Wed, 23 Mar 2022 23:52:06 +0000, Jacob Champion <pchampion(at)vmware(dot)com> wrote in
> On Wed, 2022-03-23 at 14:20 +0900, Kyotaro Horiguchi wrote:
> > I tried to write out the doc part. What do you think about it?
>
> I like it, thanks! I've applied that in v10, with a tweak to two
> iPAddress spellings and a short expansion of the condition in the Note,
> and I've added you as a co-author to 0002.

I'm fine with it. Thanks. I marked it as Ready-for-Commiter.

Note for the patch set:

0001 is preliminary patch to move inet_pton out of src/backend tree.

0002 is the main patch of this patchset

0003 is optional, which introduces pg_inet_pton() only works for IPv6
addresses. 0002 gets the same effect by the following use of
pg_inet_net_pton().

> if (!strchr(host, '/')
> && pg_inet_net_pton(PGSQL_AF_INET6, host, addr, -1) == 128)

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2022-03-24 08:27:40 Re: Assert in pageinspect with NULL pages
Previous Message Julien Rouhaud 2022-03-24 08:08:38 Re: Allow file inclusion in pg_hba and pg_ident files