Re: Replication slot drop message is sent after pgstats shutdown.

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: noah(at)leadboat(dot)com
Cc: andres(at)anarazel(dot)de, sawada(dot)mshk(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Replication slot drop message is sent after pgstats shutdown.
Date: 2022-03-18 09:18:07
Message-ID: 20220318.181807.1663734656386361087.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Fri, 18 Mar 2022 00:28:37 -0700, Noah Misch <noah(at)leadboat(dot)com> wrote in
> ===
> diff -U3 /export/home/nm/farm/studio64v12_6/HEAD/pgsql/contrib/test_decoding/expected/slot_creation_error.out /export/home/nm/farm/studio64v12_6/HEAD/pgsql.build/contrib/test_decoding/output_iso/results/slot_creation_error.out
> --- /export/home/nm/farm/studio64v12_6/HEAD/pgsql/contrib/test_decoding/expected/slot_creation_error.out Tue Feb 15 06:58:14 2022
> +++ /export/home/nm/farm/studio64v12_6/HEAD/pgsql.build/contrib/test_decoding/output_iso/results/slot_creation_error.out Tue Feb 15 11:38:14 2022

> I plan to fix this as attached, similar to how commit c04c767 fixed the same
> challenge in detach-partition-concurrently-[34].

It looks correct and I confirmed that it works.

It looks like a similar issue with [1] but this is cleaner and stable.

[1] https://www.postgresql.org/message-id/20220304.113347.2105652521035137491.horikyota.ntt@gmail.com

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2022-03-18 09:27:49 Re: pgsql: Add option to use ICU as global locale provider
Previous Message Justin Pryzby 2022-03-18 09:06:30 Re: PROPOSAL: Support global and local disabling of indexes