Re: Corruption during WAL replay

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: robertmhaas(at)gmail(dot)com
Cc: deniel1495(at)mail(dot)ru, ibrar(dot)ahmad(at)gmail(dot)com, tejeswarm(at)hotmail(dot)com, andres(at)anarazel(dot)de, hlinnaka(at)iki(dot)fi, masahiko(dot)sawada(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org, hexexpert(at)comcast(dot)net
Subject: Re: Corruption during WAL replay
Date: 2022-03-18 01:21:09
Message-ID: 20220318.102109.162855329039722212.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Wed, 16 Mar 2022 10:14:56 -0400, Robert Haas <robertmhaas(at)gmail(dot)com> wrote in
> Hmm. I think the last two instances of "buffers" in this comment
> should actually say "blocks".

Ok. I replaced them with "blocks" and it looks nicer. Thanks!

> > I'll try that, if you are already working on it, please inform me. (It
> > may more than likely be too late..)
>
> If you want to take a crack at that, I'd be delighted.

Finally, no two of from 10 to 14 doesn't accept the same patch.

As a cross-version check, I compared all combinations of the patches
for two adjacent versions and confirmed that no hunks are lost.

All versions pass check world.

The differences between each two adjacent versions are as follows.

master->14:

A hunk fails due to the change in how to access rel->rd_smgr.

14->13:

Several hunks fail due to simple context differences.

13->12:

Many hunks fail due to the migration of delayChkpt from PGPROC to
PGXACT and the context difference due to change of FSM trancation
logic in RelationTruncate.

12->11:

Several hunks fail due to the removal of volatile qalifier from
pointers to PGPROC/PGXACT.

11-10:

A hunk fails due to the context difference due to an additional
member tempNamespaceId of PGPROC.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
0001-Fix-possible-recovery-trouble-if-TRUNCATE-overlaps-a.patch text/x-patch 17.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2022-03-18 01:23:44 Re: XID formatting and SLRU refactorings
Previous Message Kyotaro Horiguchi 2022-03-18 01:20:08 Re: XID formatting and SLRU refactorings