Re: Allow file inclusion in pg_hba and pg_ident files

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Allow file inclusion in pg_hba and pg_ident files
Date: 2022-03-16 03:53:25
Message-ID: 20220316035325.zqtgmjq42wrifg3h@jrouhaud
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


The cfbot says that the patch doesn't apply anymore, so here's a v3 with the
changes mentioned below.

On Tue, Mar 01, 2022 at 05:19:50PM +0800, Julien Rouhaud wrote:
> If you prefer to interleave static and non static function I can change it.

Change the split to not reorder functions.

> > +#include "utils/guc.h"
> > +//#include "utils/tuplestore.h"
> Yes I noticed this one this morning. I didn't want to send a new patch version
> just for that, but I already fixed it locally.


> Yes I'm aware of that thread. I will be happy to change the patch to use
> MakeFuncResultTuplestore() as soon as it lands. Thanks for the notice though.

Done, with the new SetSingleFuncCall().

> > It could be possible to do installcheck on an instance that has user
> > mappings meaning that this had better be ">= 0", no?
> I thought about it, and supposed it would bring a bit more value with the test
> like that. I can change it if you prefer.

Change this way.

Attachment Content-Type Size
v3-0001-Extract-view-processing-code-from-hba.c.patch text/plain 31.9 KB
v3-0002-Add-a-pg_ident_file_mappings-view.patch text/plain 18.8 KB
v3-0003-Allow-file-inclusion-in-pg_hba-and-pg_ident-files.patch text/plain 27.1 KB
v3-0004-POC-Add-a-pg_hba_matches-function.patch text/plain 6.7 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2022-03-16 04:20:25 Re: Skipping logical replication transactions on subscriber side
Previous Message Michael Paquier 2022-03-16 03:42:23 Re: Assert in pageinspect with NULL pages