Re: support for MERGE

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Daniel Westermann <dwe(at)dbi-services(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>
Subject: Re: support for MERGE
Date: 2022-03-09 17:38:03
Message-ID: 202203091738.ctejk5vrkmcm@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

I attach MERGE v14. This includes a fix from Amit Langote for the
problem I described previously, with EvalPlanQual not working correctly.
(I had failed to short-circuit the cross-partition update correctly.)
Now the test case is enabled again, and it passes with the correct

0001 is as before; the only change is that I've added a commit message.
Since this just moves some code around, I intend to get it pushed very

0002 is the ExecUpdate/ExecDelete split. I cleaned up the struct
definitions a bit more, but it's pretty much as in the previous version.

0003 is the actual MERGE implementation. Many previous review comments
have been handled, and several other things are cleaner than before.
I haven't made any changes for work_mem handling in ModifyTable's
transition tables, though, and haven't attempted to address concurrent

Álvaro Herrera 39°49'30"S 73°17'W —

Attachment Content-Type Size
v14-0001-Add-API-of-sorts-for-transition-table-handling-i.patch text/x-diff 8.3 KB
v14-0002-Split-ExecUpdate-and-ExecDelete-in-reusable-piec.patch text/x-diff 38.8 KB
v14-0003-MERGE-SQL-Command-following-SQL-2016.patch text/x-diff 380.6 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2022-03-09 17:40:53 Re: Proposal: Support custom authentication methods using hooks
Previous Message Stephen Frost 2022-03-09 17:19:23 Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file