| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set |
| Date: | 2022-03-02 08:01:17 |
| Message-ID: | 20220302080117.ravc7rkyqjzlzqqr@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022-02-15 13:02:41 +0900, Michael Paquier wrote:
> >> + @regress_command = (@regress_command, @extra_opts);
> >> +
> >> + $oldnode->command_ok(@regress_command,
> >> + 'regression test run on old instance');
> >
> > I also think this should take EXTRA_REGRESS_OPTS into account - test.sh did.
>
> This is already taken into account, as of the @extra_opts bits.
But in a bad way, because EXTRA_REGRESS_OPTS now always wins, even for stuff
we want to override. Note how test.sh explicitly specifies port, bindir etc
after the pre-existing EXTRA_REGRESS_OPTS.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-03-02 08:07:29 | Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set |
| Previous Message | Kyotaro Horiguchi | 2022-03-02 07:59:09 | Re: standby recovery fails (tablespace related) (tentative patch and discussion) |