| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | sk(at)zsrv(dot)org |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: definition of CalculateMaxmumSafeLSN |
| Date: | 2022-03-01 01:11:03 |
| Message-ID: | 20220301.101103.2231760568010660101.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Mon, 28 Feb 2022 17:01:10 +0300, Sergei Kornilov <sk(at)zsrv(dot)org> wrote in
> Hello
> I just spotted in src/include/access/xlog.h:
> extern XLogRecPtr CalculateMaxmumSafeLSN(void);
>
> This function doesn't seem to be used anywhere or even defined? "git grep CalculateMaxmumSafeLSN" shows only this line.
> Was added in c6550776394e25c1620bc8258427c8f1d448080d "Allow users to limit storage reserved by replication slots"
Hmm. I think I remember of that name. You're right, it is a function
that was once added during development of the commit but eventually
gone.
So it should be removed.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2022-03-01 01:20:53 | Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages |
| Previous Message | Peter Smith | 2022-03-01 00:49:14 | Re: Optionally automatically disable logical replication subscriptions on error |