Re: Typo in pgbench messages.

On Thu, 24 Feb 2022 14:44:05 +0100
Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:

> > On 24 Feb 2022, at 13:58, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
>
> >> One argument against a backpatch is that this would be disruptive with
> >> tools that parse and analyze the output generated by pgbench. Fabien,
> >> don't you have some tools and/or wrappers doing exactly that?
> >
> > Yep, I like to "| cut -d' ' -fx" and other "line.split(' ')" or whatever.
> >
> > I think that the break of typographical rules is intentional to allow such simplistic low-level stream handling through pipes or scripts. I'd prefer that the format is not changed. Maybe a comment could be added to explain the reason behind it.
>
> That doesn't sound like an overwhelmingly convincing argument to print some
> messages with 'X %' and others with 'X%'.

I agree with Daniel. If inserting a space in front of % was intentional for
handling the result in such tools, we should fix other places where 'X%' is
used in the pgbench output.

Regards,
Yugo Nagata

--
Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>