Re: Patch a potential memory leak in describeOneTableDetails()

At Mon, 21 Feb 2022 10:24:23 +0100, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote in
> I think it's because you've indented your new code differently from the
> existing, such that the if (res) clause is indented equally to the previous
> pg_free(tableinfo.relam) call, making it look like they are in the same block:

Yeah, I (wrongly) thought that they have the same indentation.

> > + if (tableinfo.relam)
> > + pg_free(tableinfo.relam);
> >
> > if (res)
> > PQclear(res);

But actually the lines I added are space-indented but the following
existing line is tab-indented.

Anyway, don't we use the -ftabstop option flag to silence compiler?
The warning is contradicting our convention. The attached adds that
flag.

By the way, the doc says that:

https://www.postgresql.org/docs/14/source-format.html

> The text browsing tools more and less can be invoked as:
> more -x4
> less -x4
> to make them show tabs appropriately.

But AFAICS the "more" command on CentOS doesn't have -x options nor
any option to change tab width and I don't find a document that
suggests its existence on other platforms.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center