From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
---|---|
To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Nonrandom scanned_pages distorts pg_class.reltuples set by VACUUM |
Date: | 2022-02-17 13:46:06 |
Message-ID: | 20220217134606.GJ31460@telsasoft.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Feb 16, 2022 at 07:43:09PM -0800, Peter Geoghegan wrote:
> > I also have a hard time making heads or tails out of the commit message of
> > 44fa84881ff. It's quite long without being particularly descriptive. The
> > commit just changes a lot of things at once, making it hard to precisely
> > describe and very hard to review and understand.
>
> The commit message is high level. The important point is that we can
> more or less treat all scanned_pages the same, without generally
> caring about whether or not a cleanup lock could be acquired (since
> the exceptions where that isn't quite true are narrow and rare). That
> is the common theme, for everything.
As for myself, I particularly appreciated the clarity and detail of this commit
message. (I have looked at the associated change a bit, but not deeply).
Thanks,
--
Justin
From | Date | Subject | |
---|---|---|---|
Next Message | Imseih (AWS), Sami | 2022-02-17 13:52:23 | Re: Add index scan progress to pg_stat_progress_vacuum |
Previous Message | Ashutosh Bapat | 2022-02-17 13:30:39 | Re: postgres_fdw and skip locked |