| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: libpq async duplicate error results |
| Date: | 2022-02-17 01:11:09 |
| Message-ID: | 20220217011109.edkms5f2iqr3ofmv@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2022-02-16 18:51:37 -0500, Tom Lane wrote:
> This seems workable, and you'll notice it fixes the duplicated text
> in the test case Andres was worried about.
Cool.
I find it mildly scary that we didn't have any other tests verifying the libpq
side of connection termination. Seems like we we maybe should add a few more?
Some simple cases we can do via isolationtester. But some others would
probably require a C test program to be robust...
> + /* Also, do nothing if the argument is OOM_result */
> + if (res == unconstify(PGresult *, &OOM_result))
> + return;
Wouldn't it make more sense to make res const, rather than unconstifying
&OOM_result?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2022-02-17 01:16:13 | Re: Nonrandom scanned_pages distorts pg_class.reltuples set by VACUUM |
| Previous Message | Nathan Bossart | 2022-02-17 01:10:53 | Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file |