| From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Subject: | Re: Avoiding smgrimmedsync() during nbtree index builds |
| Date: | 2022-02-13 14:33:13 |
| Message-ID: | 20220213143313.vhwg5ua6dcevbhlj@erthalion.local |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Wed, Feb 09, 2022 at 01:49:30PM -0500, Melanie Plageman wrote:
> Hi,
> v5 attached and all email feedback addressed below
Thanks for the patch, it looks quite good.
I don't see it in the discussion, so naturally curious -- why directmgr
is not used for bloom index, e.g. in blbuildempty?
> On Sun, Jan 16, 2022 at 3:26 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> > Separate from this issue, I wonder if it'd be useful to write a DEBUG log
> > showing when btree uses shared_buffers vs fsync. And a regression test which
> > first SETs client_min_messages=debug to capture the debug log to demonstrate
> > when/that new code path is being hit. I'm not sure if that would be good to
> > merge, but it may be useful for now.
I can't find the thread right away, but I vaguely remember a similar
situation where such approach, as a main way to test the patch, had
caused some disagreement. Of course for the development phase it would
be indeed convenient.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yura Sokolov | 2022-02-13 14:35:38 | Re: Error "initial slot snapshot too large" in create replication slot |
| Previous Message | vignesh C | 2022-02-13 14:04:05 | Re: Identify missing publications from publisher while create/alter subscription. |