| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Christoph Berg <myon(at)debian(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Add TAP test to automate the equivalent of check_guc |
| Date: | 2022-02-12 20:10:46 |
| Message-ID: | 20220212201046.uyc2yootpaguph3o@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hi,
On 2022-02-12 13:29:54 +0900, Michael Paquier wrote:
> On Sat, Feb 12, 2022 at 09:49:47AM +0900, Michael Paquier wrote:
> > I guess that it would be better to revert the TAP test and rework all
> > that for the time being, then.
>
> And this part is done.
You wrote in the commit message that:
"However, this is also an issue as a TAP test only offers the build directory
as of TESTDIR in the environment context, so this would fail with VPATH
builds."
Tap tests currently are always executed in the source directory above t/, as
far as I can tell. So I don't think VPATH/non-VPATH or windows / non-windows
would break using a relative reference from the test dir.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-02-12 22:04:13 | Re: pgsql: Add decoding of sequences to test_decoding |
| Previous Message | Tom Lane | 2022-02-12 19:00:20 | pgsql: Move libpq's write_failed mechanism down to pqsecure_raw_write() |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matheus Alcantara | 2022-02-12 20:17:29 | [PATCH] Add tests for psql tab completion |
| Previous Message | Tomas Vondra | 2022-02-12 19:58:53 | Re: logical decoding and replication of sequences |