| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | masao(dot)fujii(at)oss(dot)nttdata(dot)com |
| Cc: | katouknl(at)oss(dot)nttdata(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Add min() and max() aggregate functions for xid8 |
| Date: | 2022-02-09 04:04:44 |
| Message-ID: | 20220209.130444.142792436041672984.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Wed, 09 Feb 2022 12:04:51 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> At Wed, 9 Feb 2022 11:01:57 +0900, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote in
> > Agreed. So barring any objection, I will commit that patch.
>
> Sorry for being late, but I don't like the function names.
>
> +xid8_larger(PG_FUNCTION_ARGS)
> +xid8_smaller(PG_FUNCTION_ARGS)
>
> Aren't they named like xid8gt and xid8lt conventionally? At least the
> name lacks a mention to equality.
Ah, sorry. the function returns larger/smaller one from the
parameters. Sorry for the noise.
regardes.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2022-02-09 04:46:52 | Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints |
| Previous Message | Robert Haas | 2022-02-09 03:57:37 | Re: make MaxBackends available in _PG_init |