Re: archive modules

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "Bossart, Nathan" <bossartn(at)amazon(dot)com>, David Steele <david(at)pgmasters(dot)net>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>
Subject: Re: archive modules
Date: 2022-01-30 05:01:41
Message-ID: 20220130050141.GA582209@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Sat, Jan 29, 2022 at 04:31:48PM -0800, Nathan Bossart wrote:
> On Sat, Jan 29, 2022 at 12:50:18PM -0800, Nathan Bossart wrote:
>> Here is a new revision. I've moved basic_archive to contrib, hardened it
>> as suggested, and added shutdown support for archive modules.
> cfbot was unhappy with v14, so here's another attempt. One other change I
> am pondering is surrounding pgarch_MainLoop() with PG_TRY/PG_FINALLY so
> that we can also call the shutdown callback in the event of an ERROR. This
> might be necessary for an archive module that uses background workers.

Ugh. Apologies for the noise. cfbot still isn't happy, so here's yet
another attempt. This new patch set also ensures the shutdown callback is
called when the archiver process exits.

Nathan Bossart
Amazon Web Services:

Attachment Content-Type Size
v16-0001-Introduce-archive-modules-infrastructure.patch text/x-diff 12.0 KB
v16-0002-Add-test-archive-module.patch text/x-diff 11.5 KB
v16-0003-Add-documentation-for-archive-modules.patch text/x-diff 30.6 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Dilger 2022-01-30 05:58:38 Re: CREATEROLE and role ownership hierarchies
Previous Message Peter Geoghegan 2022-01-30 04:42:36 Re: Removing more vacuumlazy.c special cases, relfrozenxid optimizations