|From:||Andres Freund <andres(at)anarazel(dot)de>|
|To:||Magnus Hagander <magnus(at)hagander(dot)net>|
|Cc:||Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org|
|Subject:||Re: pg_basebackup WAL streamer shutdown is bogus - leading to slow tests|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On 2022-01-29 12:44:22 -0800, Andres Freund wrote:
> On 2022-01-17 10:06:56 -0800, Andres Freund wrote:
> > Yes, that's what I was suggesting. I wasn't thinking of using a static var,
> > but putting it in StreamCtl. Note that what pgwin32_waitforsinglesocket()
> > is doing doesn't protect against the problem referenced above, because it
> > still is reset by WSAEventSelect.
> Do we are about breaking StreamCtl ABI? I don't think so?
Here's a version of the patch only creating the event once. Needs a small bit
of comment polishing, but otherwise I think it's sane?
|Next Message||Alvaro Herrera||2022-01-29 21:49:37||Re: support for MERGE|
|Previous Message||Andres Freund||2022-01-29 21:02:14||Re: Windows crash / abort handling|