| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | wenjing zeng <wjzeng2012(at)gmail(dot)com> |
| Cc: | Rachel Heaton <rachelmheaton(at)gmail(dot)com>, Gareth Palmer <gareth(at)internetnz(dot)net(dot)nz>, movead li <movead(dot)li(at)highgo(dot)ca>, david(at)pgmasters(dot)net, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: [PATCH] Implement INSERT SET syntax |
| Date: | 2022-01-24 03:58:05 |
| Message-ID: | 20220124035805.GS23027@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Fri, Jan 21, 2022 at 05:24:51PM +0800, wenjing zeng wrote:
> Since this feature adds INSERT OVERRIDING SET syntax, it is recommended to add some related testcases.
Thanks for proposing some more tests.
Note that your patch caused Gareth's patches to break under the cfbot.
http://cfbot.cputube.org/gareth-palmer.html
You have to either include the pre-requisite patches as 0001, and your patch as
0002 (as I'm doing now), or name your patch something other than *.diff or
*.patch, so cfbot doesn't think it's a new version of the patch to be tested.
Thanks,
--
Justin
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Implement-INSERT-SET-syntax.patch | text/x-diff | 14.9 KB |
| 0002-Since-this-feature-adds-INSERT-OVERRIDING-SET-syntax.patch | text/x-diff | 2.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-01-24 03:58:34 | Re: [BUG]Update Toast data failure in logical replication |
| Previous Message | Robert Haas | 2022-01-24 03:52:14 | Re: fairywren is generating bogus BASE_BACKUP commands |