Re: pgsql: Test replay of regression tests, attempt II.

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Thomas Munro <tmunro(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Test replay of regression tests, attempt II.
Date: 2022-01-18 23:08:38
Message-ID: 20220118230838.amvazn2ig4cf56oy@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On 2022-01-18 17:19:06 -0500, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > That's an extremely small shared_buffers for running the regression tests, it'd not
> > be surprising if that provoked problems we don't otherwise see. Perhaps VACUUM
> > ends up skipping over a page because of page contention?
>
> Hmm, good thought. I tried running the test with even smaller
> shared_buffers, but could not make the reloptions test fall over for
> me. But this theory implies a strong timing dependency, so it might
> still only happen on particular machines. (If anyone else tries it:
> below about 400kB, other tests start failing with "no free unpinned
> buffers" and the like.)

I ran the test in a loop for 200+ times now, without reproducing the
problem. Rorqual runs on a shared machine though, so it's quite possible that
IO will be slower, and thus triggering the issue.

I was wondering whether we could use VACUUM VERBOSE for that specific VACUUM -
that'd show information about the number of pages with tuples etc. But I don't
currently see a way of that causing the regression tests to fail.

Even if I set client_min_messages=error, the messages still get sent to the
client, because elevel == INFO is special cased in
should_output_to_client(). And I don't see a way of redirecting the output of
common.c:NoticeProcessor() in psql either.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2022-01-19 01:38:43 pgsql: doc: Fix description of pg_replication_origin_oid() in error cas
Previous Message Thomas Munro 2022-01-18 22:29:04 Re: pgsql: Test replay of regression tests, attempt II.