Re: default to to ON_ERROR_STOP=on (Re: psql: exit status with multiple -c and -f)

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)postgresql(dot)org, Robert Haas <rhaas(at)postgresql(dot)org>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Subject: Re: default to to ON_ERROR_STOP=on (Re: psql: exit status with multiple -c and -f)
Date: 2022-01-17 00:10:43
Message-ID: 20220117001043.hgjci4zqt3l4susa@jrouhaud
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


On Mon, Dec 27, 2021 at 12:31:07PM -0500, Tom Lane wrote:
> Justin Pryzby <pryzby(at)telsasoft(dot)com> writes:
> > I think the current behavior of the regression test SQL scripts is exactly the
> > opposite of what's desirable for almost all other scripts. The attached makes
> > ON_ERROR_STOP the default, and runs the regression tests with ON_ERROR_STOP=0.
> > Is it viable to consider changing this ?
> I don't think so. The number of scripts you will break is far greater
> than the number whose behavior will be improved, because people who
> wanted this behavior will already be selecting it. Maybe this wasn't
> the greatest choice of default, but it's about twenty years too late
> to change it.
> I'd also note that I see a fairly direct parallel to "set -e" in
> shell scripts, which is likewise not the default.
> We could consider documentation changes to make this issue
> more visible, perhaps. Not sure what would be a good place.

I'm marking the CF entry as returned with feedback as it's been a few weeks
without proposal for documentation change.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2022-01-17 00:28:03 Time to increase hash_mem_multiplier default?
Previous Message Tomas Vondra 2022-01-16 23:44:50 Re: extended stats on partitioned tables