| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Robert Haas <rhaas(at)postgresql(dot)org>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Subject: | Re: default to to ON_ERROR_STOP=on (Re: psql: exit status with multiple -c and -f) |
| Date: | 2021-12-27 17:31:07 |
| Message-ID: | 1513136.1640626267@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Justin Pryzby <pryzby(at)telsasoft(dot)com> writes:
> I think the current behavior of the regression test SQL scripts is exactly the
> opposite of what's desirable for almost all other scripts. The attached makes
> ON_ERROR_STOP the default, and runs the regression tests with ON_ERROR_STOP=0.
> Is it viable to consider changing this ?
I don't think so. The number of scripts you will break is far greater
than the number whose behavior will be improved, because people who
wanted this behavior will already be selecting it. Maybe this wasn't
the greatest choice of default, but it's about twenty years too late
to change it.
I'd also note that I see a fairly direct parallel to "set -e" in
shell scripts, which is likewise not the default.
We could consider documentation changes to make this issue
more visible, perhaps. Not sure what would be a good place.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-12-27 17:34:16 | Re: Inconsistent ellipsis in regression test error message? |
| Previous Message | Corey Huinker | 2021-12-27 17:22:52 | Re: Foreign key joins revisited |