| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | kingsboa(at)amazon(dot)com |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Null commitTS bug |
| Date: | 2022-01-17 02:17:24 |
| Message-ID: | 20220117.111724.632185256127324915.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Fri, 14 Jan 2022 22:49:59 +0000, "Kingsborough, Alex" <kingsboa(at)amazon(dot)com> wrote in
> The fix for this is very simple
>
>
> /* if we wrote out all subxids, we're done. /
> - if (j + 1 >= nsubxids)
> + if (j >= nsubxids)
> break;
It looks like a thinko and the fix is correct. (It's a matter of taste
choosing between it and "j == nsubxids").
I found some confusing lines around but they need not a fix
considering back-patching conflict?
> for (i = 0, headxid = xid;;)
..
> i += j - i + 1;
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-01-17 03:15:51 | Re: Consistently use the function name CreateCheckPoint instead of CreateCheckpoint in code comments |
| Previous Message | Michael Paquier | 2022-01-17 02:12:36 | Re: Add jsonlog log_destination for JSON server logs |