| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_basebackup WAL streamer shutdown is bogus - leading to slow tests |
| Date: | 2022-01-16 23:31:18 |
| Message-ID: | 20220116233118.gtczuhiposgncmf2@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2022-01-16 15:28:00 -0800, Andres Freund wrote:
> I hacked that up last night. And a fix or two later, it seems to be
> working. What I'd missed at first is that the event needs to be reset in
> reached_end_position(), otherwise we'll busy loop.
>
> I wonder if using a short-lived event handle would have dangers of missing
> FD_CLOSE here as well? It'd probably be worth avoiding the risk by creating
> the event just once.
>
> I just wasn't immediately sure where to stash it. Probably just by adding a
> field in StreamCtl, that ReceiveXlogStream() then sets? So far it's constant
> once passed to ReceiveXlogStream(), but I don't really see a reason why it'd
> need to stay that way?
Oops, attached the patch this time.
Greetings,
Andres Freund
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Avoid-slow-shutdown-of-pg_basebackup-windows-edit.patch | text/x-diff | 8.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2022-01-16 23:44:50 | Re: extended stats on partitioned tables |
| Previous Message | Andres Freund | 2022-01-16 23:28:00 | Re: pg_basebackup WAL streamer shutdown is bogus - leading to slow tests |