| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com> |
| Cc: | Amul Sul <sulamul(at)gmail(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Multi-Column List Partitioning |
| Date: | 2022-01-14 09:49:15 |
| Message-ID: | 20220114094915.cduei6xvmyrnozep@jrouhaud |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
The cfbot reports some clang warning on the last version of the patchset:
https://cirrus-ci.com/task/6721617647632384
[16:35:24.444] partprune.c:2775:8: error: explicitly assigning value of variable of type 'int' to itself [-Werror,-Wself-assign]
[16:35:24.444] off = off;
[16:35:24.444]
A quick look at the patch seems to indicate that it's harmless dead code that
should be removed, and there are no other failure reported by the cfbot, but I
definitely didn't read the patch carefully so a confirmation (and an updated
patch) would be welcome.
However I see that Amul raised some concerns, so I will change the patch status
to Waiting on Author. Feel free to switch it back to Needs Review if you think
it's more appropriate.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sergey Shinderuk | 2022-01-14 10:01:39 | Re: Windows: Wrong error message at connection termination |
| Previous Message | Julien Rouhaud | 2022-01-14 09:28:38 | Re: MultiXact\SLRU buffers configuration |