| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: null iv parameter passed to combo_init() |
| Date: | 2022-01-13 02:49:33 |
| Message-ID: | 20220113024933.GB413996@rfd.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 10, 2022 at 03:34:27PM -0800, Zhihong Yu wrote:
> On Sun, Jan 9, 2022 at 6:45 PM Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
> > gcc -Wall -Wmissing-prototypes -Wpointer-arith
> > -Wdeclaration-after-statement -Werror=vla -Wendif-labels
> > -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type
> > -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard
> > -Wno-format-truncation -Wno-stringop-truncation -fsanitize=undefined
> > -fsanitize-undefined-trap-on-error -I../../src/port -DFRONTEND
> > -I../../src/include -D_GNU_SOURCE -c -o path.o path.c
>
> Patch v3 passes `make check-world`
The patch uses the "LENGTH_VAR != 0" style in px.c, but it uses "POINTER_VAR
!= NULL" style in the other files. Please use "LENGTH_VAR != 0" style in each
place you're changing.
Assuming the next version looks good, I'll likely back-patch it to v10. Would
anyone like to argue for a back-patch all the way to 9.2?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2022-01-13 02:54:44 | Re: postgres_fdw: commit remote (sub)transactions in parallel during pre-commit |
| Previous Message | Andres Freund | 2022-01-13 02:25:26 | Re: Windows vs recovery tests |