From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Deduplicate min restart_lsn calculation code |
Date: | 2022-01-06 18:24:49 |
Message-ID: | 202201061824.wiiewcagwo43@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2022-Jan-06, Bharath Rupireddy wrote:
> Hi,
>
> It seems like the two functions ReplicationSlotsComputeRequiredLSN and
> ReplicationSlotsComputeLogicalRestartLSN more or less does the same
> thing which makes me optimize (saving 40 LOC) it as attached. I'm
> pretty much okay if it gets rejected on the grounds that it creates a
> lot of diff with the older versions and the new API may not look
> nicer, still I want to give it a try.
>
> Thoughts?
Hmm, it seems sensible to me. But I would not have the second boolean
argument in the new function, and instead have the caller save the
return value in a local variable to do the XLogSetReplicationSlotMinimumLSN
step separately. Then the new function API is not so strange.
--
Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/
"Linux transformó mi computadora, de una `máquina para hacer cosas',
en un aparato realmente entretenido, sobre el cual cada día aprendo
algo nuevo" (Jaime Salinas)
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2022-01-06 18:28:44 | Re: pl/pgsql feature request: shorthand for argument and local variable references |
Previous Message | Peter Geoghegan | 2022-01-06 18:21:32 | Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output |