| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Column Filtering in Logical Replication |
| Date: | 2022-01-03 15:01:59 |
| Message-ID: | 202201031501.gn2mtdiklb5y@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022-Jan-03, Justin Pryzby wrote:
> Yes, I know both paths are hit now that it uses GetBool.
>
> What I'm wondering is why tests didn't fail when one path wasn't hit - when it
> said am_partition=DatumGetChar(); if (!am_partition){}
Ah!
> I suppose it's because the am_partition=true case correctly handles
> nonpartitions.
>
> Maybe the !am_partition case should be removed, and add a comment that
> pg_partition_tree(pg_partition_root(%u))) also handles non-partitions.
> Or maybe that's inefficient...
Hmm, that doesn't sound true. Running the query manually, you get an
empty list if you use pg_partition_tree(pg_partition_root) with a
non-partition. Maybe what was happening is that all columns were being
transmitted instead of only the required columns. Maybe you're right
that the test isn't complete enough.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-01-03 15:11:42 | Re: Remove inconsistent quotes from date_part error |
| Previous Message | Tom Lane | 2022-01-03 14:57:14 | Re: Index-only scans vs. partially-retrievable indexes |