| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | "Imseih (AWS), Sami" <simseih(at)amazon(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Add index scan progress to pg_stat_progress_vacuum |
| Date: | 2021-12-29 17:51:21 |
| Message-ID: | 20211229175121.GP24477@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
http://cfbot.cputube.org/sami-imseih.html
You should run "make check" and update rules.out.
You should also use make check-world - usually something like:
make check-world -j4 >check-world.out 2>&1 ; echo ret $?
> indrelid: The relid of the index currently being vacuumed
I think it should be called indexrelid not indrelid, for consistency with
pg_index.
> S.param10 vacuum_cycle_ordinal_position,
> S.param13 index_rows_vacuumed
These should both say "AS" for consistency.
system_views.sql is using tabs, but should use spaces for consistency.
> #include "commands/progress.h"
The postgres convention is to alphabetize the includes.
> /* VACCUM operation's longest index scan cycle */
VACCUM => VACUUM
Ultimately you'll also need to update the docs.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | SATYANARAYANA NARLAPURAM | 2021-12-29 18:54:06 | Re: Report checkpoint progress in server logs |
| Previous Message | Sadhuprasad Patro | 2021-12-29 17:08:11 | Per-table storage parameters for TableAM/IndexAM extensions |