From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
---|---|
To: | Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io> |
Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Proposal: More structured logging |
Date: | 2021-12-29 13:59:16 |
Message-ID: | 20211229135916.GN24477@telsasoft.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> Subject: [PATCH v3 2/3] Add test module for the new tag functionality.
...
> +test_logging(PG_FUNCTION_ARGS)
> +{
...
> + (errmsg("%s", message),
> + ({
> + forboth(lk, keys, lv, values)
> + {
> + (errtag(lfirst(lk), "%s", (char *) lfirst(lv)));
> + }})
> + ));
The windows build fails with that syntax.
http://cfbot.cputube.org/ronan-dunklau.html
https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.157923
> Subject: [PATCH v3 3/3] Output error tags in CSV logs
> +++ b/doc/src/sgml/config.sgml
> @@ -7370,6 +7371,7 @@ CREATE TABLE postgres_log
> backend_type text,
> leader_pid integer,
> query_id bigint,
> + tags jsonb
> PRIMARY KEY (session_id, session_line_num)
> );
> </programlisting>
That's invalid sql due to missing a trailing ",".
You should also update file-fdw.sgml - which I only think of since we forgot in
to update it before e568ed0eb and 0830d21f5. config.sgml should have a comment
as a reminder to do that.
--
Justin
From | Date | Subject | |
---|---|---|---|
Next Message | Bharath Rupireddy | 2021-12-29 14:30:54 | Report checkpoint progress in server logs |
Previous Message | Nitin Jadhav | 2021-12-29 13:58:19 | Re: Multi-Column List Partitioning |