| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: PublicationActions - use bit flags. |
| Date: | 2021-12-20 17:14:01 |
| Message-ID: | 202112201714.ql732mnfdrtc@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Dec-20, Peter Eisentraut wrote:
> I don't see why this is better. It just makes the code longer and adds more
> punctuation and reduces type safety.
Removing one palloc is I think the most important consequence ...
probably not a big deal though.
I think we could change the memcpy calls to struct assignment, as that
would look a bit cleaner, and call it a day.
One thing I would not like would be to change the catalog representation
from bools into an integer. We do that for pg_trigger.tgflags (IIRC)
and it is horrible.
--
Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joshua Brindle | 2021-12-20 17:27:11 | Re: Support for NSS as a libpq TLS backend |
| Previous Message | Tom Lane | 2021-12-20 16:56:40 | Re: PublicationActions - use bit flags. |