Re: [PATCH] pg_stat_toast

Hi,

On 2021-12-12 17:20:58 +0100, Gunnar "Nick" Bluth wrote:
> Please have a look at the attached patch, which implements some statistics
> for TOAST.
>
> The idea (and patch) have been lurking here for quite a while now, so I
> decided to dust it off, rebase it to HEAD and send it out for review today.
>
> A big shoutout to Georgios Kokolatos, who gave me a crash course in PG
> hacking, some very useful hints and valueable feedback early this year.
>
> I'd like to get some feedback about the general idea, approach, naming etc.
> before refining this further.

I'm worried about the additional overhead this might impose. For some workload
it'll substantially increase the amount of stats traffic. Have you tried to
qualify the overheads? Both in stats size and in stats management overhead?

Greetings,

Andres Freund