Re: RecoveryInProgress() has critical side effects

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andres Freund <andres(at)anarazel(dot)de>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, amul sul <sulamul(at)gmail(dot)com>
Subject: Re: RecoveryInProgress() has critical side effects
Date: 2021-12-01 16:38:25
Message-ID: 202112011638.cwy2uqzladjq@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

There are a couple typos. "uninitalized," in one place.

Also,

+ * If this is either a bootstrap process nor a standalone backend, start

Is "either .. nor" correct? It looks very wrong to me. I think you
meant "either .. or".

Overall, this patch seems mostly about documenting some undesirable
existing behavior. Is part of your plan to get such things fixed/
replaced entirely?

--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
"We're here to devour each other alive" (Hobbes)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-12-01 17:26:06 Re: Correct handling of blank/commented lines in PSQL interactive-mode history
Previous Message David Steele 2021-12-01 16:27:42 Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file