| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Some RELKIND macro refactoring |
| Date: | 2021-11-23 15:19:13 |
| Message-ID: | 202111231519.kf27gjzikeko@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Nov-22, Peter Eisentraut wrote:
> Maybe
>
> else
> {
> Assert(RELKIND_HAS_STORAGE(rel->rd_rel->relkind);
> RelationCreateStorage(rel->rd_node, relpersistence);
> }
>
> create_storage is set earlier based on RELKIND_HAS_STORAGE(), so this would
> be consistent.
Hmm, right ... but I think we can make this a little simpler. How about
the attached?
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
| Attachment | Content-Type | Size |
|---|---|---|
| create-storage.patch | text/x-diff | 2.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Drouvot, Bertrand | 2021-11-23 15:22:19 | Re: Patch to avoid orphaned dependencies |
| Previous Message | Alvaro Herrera | 2021-11-23 15:09:00 | Re: Some RELKIND macro refactoring |