Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?)

Hi,

On 2021-11-02 15:26:52 -0400, Melanie Plageman wrote:
> Subject: [PATCH v14 1/4] Allow bootstrap process to beinit

Pushed.

> +/*
> + * On modern systems this is really just *counter++. On some older systems
> + * there might be more to it, due to inability to read and write 64 bit values
> + * atomically.
> + */
> +static inline void inc_counter(pg_atomic_uint64 *counter)
> +{
> + pg_atomic_write_u64(counter, pg_atomic_read_u64(counter) + 1);
> +}
> +
> #undef INSIDE_ATOMICS_H

Why is this using a completely different naming scheme from the rest of the
file?

> doc/src/sgml/monitoring.sgml | 116 +++++++++++++-
> src/backend/catalog/system_views.sql | 11 ++
> src/backend/postmaster/checkpointer.c | 3 +-
> src/backend/postmaster/pgstat.c | 161 +++++++++++++++++++-
> src/backend/storage/buffer/bufmgr.c | 46 ++++--
> src/backend/storage/buffer/freelist.c | 23 ++-
> src/backend/storage/buffer/localbuf.c | 3 +
> src/backend/storage/sync/sync.c | 1 +
> src/backend/utils/activity/backend_status.c | 60 +++++++-
> src/backend/utils/adt/pgstatfuncs.c | 152 ++++++++++++++++++
> src/include/catalog/pg_proc.dat | 9 ++
> src/include/miscadmin.h | 2 +
> src/include/pgstat.h | 53 +++++++
> src/include/storage/buf_internals.h | 4 +-
> src/include/utils/backend_status.h | 80 ++++++++++
> src/test/regress/expected/rules.out | 8 +
> 16 files changed, 701 insertions(+), 31 deletions(-)

This is a pretty large change, I wonder if there's a way to make it a bit more
granular.

Greetings,

Andres Freund