Re: pgsql: Fix headerscheck failure in replication/worker_internal.h

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix headerscheck failure in replication/worker_internal.h
Date: 2021-11-16 17:09:36
Message-ID: 202111161709.u3pbx5lxdimt@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2021-Nov-16, Alvaro Herrera wrote:

> Fix headerscheck failure in replication/worker_internal.h

The other failure is in src/include/libpq/be-gssapi-common.h:

In file included from /tmp/headerscheck.a6f0um/test.c:2:
./src/include/libpq/be-gssapi-common.h:20:10: fatal error: gssapi/gssapi.h: No existe el fichero o el directorio
20 | #include <gssapi/gssapi.h>
| ^~~~~~~~~~~~~~~~~
compilation terminated.

One possible solution for this one is to add an exclusion in
headerscheck (and cpluspluscheck?); the other possible solution seems to
be to wrap the whole contents of the file in "#ifdef ENABLE_GSS". I
think the latter is roughly the approach used for OpenSSL inclusions.

--
Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2021-11-16 17:14:31 Re: pgsql: Fix headerscheck failure in replication/worker_internal.h
Previous Message Alvaro Herrera 2021-11-16 16:33:02 pgsql: Fix headerscheck failure in replication/worker_internal.h

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2021-11-16 17:14:31 Re: pgsql: Fix headerscheck failure in replication/worker_internal.h
Previous Message Tom Lane 2021-11-16 16:44:07 Re: Granting SET and ALTER SYSTE privileges for GUCs