| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: support for MERGE |
| Date: | 2021-11-12 23:13:10 |
| Message-ID: | 202111122313.fjhecfq6yi2v@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Nov-12, Zhihong Yu wrote:
> Hi,
>
> + skipped_path = total - insert_path - update_path - delete_path;
>
> Should there be an assertion that skipped_path is not negative ?
Hm, yeah, added.
> + * We maintain separate transaction tables for UPDATE/INSERT/DELETE since
> + * MERGE can run all three actions in a single statement. Note that UPDATE
> + * needs both old and new transition tables
>
> Should the 'transaction' in the first line be transition ?
Oh, of course.
Uploaded fixup commits to
https://github.com/alvherre/postgres/commits/merge-15
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-11-12 23:21:46 | Re: ALTER TABLE DETACH PARTITION violates serializability |
| Previous Message | Alvaro Herrera | 2021-11-12 23:07:04 | Re: ALTER TABLE DETACH PARTITION violates serializability |